SCSS: don't add extra comma after last comment in map#6918
Merged
lydell merged 4 commits intoprettier:masterfrom Nov 12, 2019
Merged
SCSS: don't add extra comma after last comment in map#6918lydell merged 4 commits intoprettier:masterfrom
lydell merged 4 commits intoprettier:masterfrom
Conversation
fisker
changed the title
fisker
changed the title
4 tasks
alexander-akait
approved these changes
Nov 11, 2019
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good job, thanks, in future try to avoid extra tests not related to issue, because it is hard to review
alexander-akait
requested changes
Nov 11, 2019
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Oh, problem still exists
$my-map: (
"foo": 1,
// Comment
"bar": 2,
// Comment
);Should be
$my-map: (
"foo": 1,
// Comment
"bar": 2
// Comment
);and
$my-map: (
"foo": 1,
// Comment
"bar": 2,
// Comment
);with --trailing-comma all
Member
Author
|
As I said, this PR only fix comma after the last comment. #6920 is another issue. |
alexander-akait
approved these changes
Nov 11, 2019
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Okey, let's solve this in other PR
lydell
reviewed
Nov 11, 2019
lipis
approved these changes
Nov 11, 2019
Member
|
/cc @lydell need approve 😄 |
lipis
added a commit
that referenced
this pull request
Jan 8, 2020
* 'master' of github.com:prettier/prettier: Don't lowercase element names in CSS selectors (#6947) Support string-to-package config in JSON schema: (#6941) Rename SECURITY.md to .github/SECURITY.md Create SECURITY.md Add the XML plugin to the docs (#6944) TypeScript: Fix formatting of type operators as arrow function… (#6901) SCSS: don't add extra comma after last comment in map (#6918) Remove typescript-etw from build (#6919)
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #6911
FYI:
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨