Set trailingComma default value to es5(outdated)#6910
Set trailingComma default value to es5(outdated)#6910fisker wants to merge 0 commit intoprettier:nextfrom
trailingComma default value to es5(outdated)#6910Conversation
| @@ -1,2 +1,2 @@ | |||
| run_spec(__dirname, ["typescript"], { trailingComma: "none" }); | |||
| run_spec(__dirname, ["typescript"]); | |||
There was a problem hiding this comment.
I change the test orders to help review, snap changes should only be options part
| // Comment | ||
| "bar": 2, | ||
| // Comment | ||
| // Comment, |
There was a problem hiding this comment.
this should be a scss bug, need fix with another PR
| advancedSearchService.patientInformationFieldsRow2.indexOf( | ||
| advancedSearchService.formElementData.customFieldList[i].customFieldType | ||
| ) !== -1 | ||
| ) !== -1, |
| description: | ||
| "Trailing commas where valid in ES5 (objects, arrays, etc.)" | ||
| }, | ||
| { value: "none", description: "No trailing commas." }, |
There was a problem hiding this comment.
playground shows none above es5
There was a problem hiding this comment.
I’d prefer if the order wasn’t changed, as that way, es5 is still implied to be between none and all.
There was a problem hiding this comment.
@ExE-Boss why? after changing default to es5, shouldn't we put it on the top?
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Someone can give a link where we decided that we will change it in the next version, because we only talk about what we may change, but I did not see where we decided to change it
|
Changing the default of |
fisker
force-pushed
the
trailing-comma-es5
branch
from
b7d38cb to
f99e3d9
Compare
|
accidentlly force-pushed a wrong commit, auto closed, please reopen |
|
The "Reopen" button is disabled for me. Its tooltip says: "There are no new commits on the fisker:trailing-comma-es5 branch." |
|
new PR #6963 |
fisker
changed the title
trailingComma default value to es5trailingComma default value to es5(outdated)
lock
Bot
added
the
locked-due-to-inactivity
5 participants
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨