Skip to content

Drop Node.js 4 test on CI #6907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lydell merged 6 commits into from
Nov 11, 2019
Merged

Drop Node.js 4 test on CI #6907

lydell merged 6 commits into from
Nov 11, 2019

Conversation

@fisker
Copy link
Member

@fisker fisker commented Nov 10, 2019 •
edited
Loading

As required in #6888 , drop CI test running on node 4.
It's only two month schedule, the clock is ticking, let's get started

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker mentioned this pull request Nov 10, 2019
Merged
4 tasks
@fisker fisker changed the title Drop node 4 test on CI Drop Node 4 test on CI Nov 10, 2019
@fisker fisker changed the title Drop Node 4 test on CI Drop Node.js 4 test on CI Nov 10, 2019
@lydell
Copy link
Member

lydell commented Nov 10, 2019

Nice!

I wonder if we should do 2.0 items on master or in a 2.0 branch. To me, it seems easier to do it on master (we could make a 1.x branch if we need to make another 1.x release).

@j-f1 @evilebottnawi @lipis What do think?

@fisker
Copy link
Member Author

fisker commented Nov 10, 2019 •
edited
Loading

I agree, work on master is easier.

@lipis
Copy link
Member

lipis commented Nov 10, 2019

my vote is to work on next branch instead until we release the version 2. The next branch will always be in sync with master, plus all the new changes.

@lipis
Copy link
Member

lipis commented Nov 10, 2019

Also all the new updates well be visible here #6773

@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

@lipis one question, default branch set to master or next?

@j-f1 j-f1 changed the base branch from master to next November 10, 2019 16:05
@lydell
Copy link
Member

lydell commented Nov 10, 2019

Are there no CI runs? Anyone knows why?

@j-f1
Copy link
Member

j-f1 commented Nov 10, 2019

I’m not sure. Could it be that it’s because we’re not targeting the master branch?

@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

I think its master settings

@fisker fisker changed the base branch from next to master November 10, 2019 18:38
@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

switch base to master runs , haha

@fisker fisker changed the base branch from master to next November 10, 2019 18:39
@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

still running?

@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

someone please change the one in master add next branch, Im in bed

@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

@j-f1 not here, you need change the azure-pipelines.yml in master

@fisker fisker changed the base branch from next to master November 10, 2019 18:57
@fisker fisker changed the base branch from master to next November 10, 2019 18:57
@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

can you try set next as default branch?

@fisker
Copy link
Member Author

fisker commented Nov 10, 2019

https://docs.microsoft.com/en-us/azure/devops/pipelines/release/deploy-pull-request-builds?view=azure-devops

there is a target setting

@j-f1
Copy link
Member

j-f1 commented Nov 10, 2019

Found it: https://dev.azure.com/prettier/prettier/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=5&view=Tab_Triggers, section “Pull request validation”

@fisker
Copy link
Member Author

fisker commented Nov 11, 2019

first move?

@lydell lydell merged commit 86548e5 into prettier:next Nov 11, 2019
@fisker fisker deleted the drop-node-4-test branch November 11, 2019 23:46
lipis added a commit that referenced this pull request Nov 12, 2019
@lipis
Merge branch 'next' of github.com:prettier/prettier into next
fe8f52a 
* 'next' of github.com:prettier/prettier:
  Drop Node.js 4 test on CI (#6907)
sosukesuzuki pushed a commit to sosukesuzuki/prettier that referenced this pull request Jan 2, 2020
@fisker @sosukesuzuki
Drop Node.js 4 test on CI (prettier#6907)
a3e5662
@sosukesuzuki sosukesuzuki mentioned this pull request Jan 22, 2020
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fisker @lydell @lipis @j-f1