Skip to content

Fix bin permissions #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lydell merged 4 commits into from
Nov 9, 2019
Merged

Fix bin permissions #6902

lydell merged 4 commits into from
Nov 9, 2019

Conversation

@fisker
Copy link
Member

@fisker fisker commented Nov 9, 2019

fixes: #6900 , this is a bug introduced in #6200

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

lydell
lydell reviewed Nov 9, 2019
View reviewed changes
@fisker
Copy link
Member Author

fisker commented Nov 9, 2019 •
edited
Loading

https://dev.azure.com/prettier/prettier/_build/results?buildId=2884&view=logs&jobId=afd2db75-0a23-56ec-00f6-5aec6de004e8&taskId=bdbf96c4-18ba-5e53-f741-af2442c390ef&lineStart=34&lineEnd=35&colStart=1&colEnd=1

+x added

result seems been deleted

-rwxr-xr-x 1 vsts docker 1404825 Nov  9 16:08 bin-prettier.js
-rw-r--r-- 1 vsts docker   70590 Nov  9 16:08 doc.js
-rw-r--r-- 1 vsts docker 1344851 Nov  9 16:08 index.js
-rw-r--r-- 1 vsts docker    1065 Nov  9 16:11 LICENSE
-rw-r--r-- 1 vsts docker     468 Nov  9 16:11 package.json
-rw-r--r-- 1 vsts docker   57420 Nov  9 16:10 parser-angular.js
-rw-r--r-- 1 vsts docker  266239 Nov  9 16:08 parser-babylon.js
-rw-r--r-- 1 vsts docker 1520521 Nov  9 16:09 parser-flow.js
-rw-r--r-- 1 vsts docker  139557 Nov  9 16:11 parser-glimmer.js
-rw-r--r-- 1 vsts docker   51351 Nov  9 16:11 parser-graphql.js
-rw-r--r-- 1 vsts docker  110678 Nov  9 16:11 parser-html.js
-rw-r--r-- 1 vsts docker  241112 Nov  9 16:11 parser-markdown.js
-rw-r--r-- 1 vsts docker  351826 Nov  9 16:11 parser-postcss.js
-rw-r--r-- 1 vsts docker 2632996 Nov  9 16:10 parser-typescript.js
-rw-r--r-- 1 vsts docker  167677 Nov  9 16:11 parser-yaml.js
-rw-r--r-- 1 vsts docker    3697 Nov  9 16:11 README.md
-rw-r--r-- 1 vsts docker 1058952 Nov  9 16:08 standalone.js
-rw-r--r-- 1 vsts docker  144713 Nov  9 16:08 third-party.js

@lydell lydell merged commit 1d1a901 into prettier:master Nov 9, 2019
@fisker fisker deleted the fix-bin-mod branch November 9, 2019 16:45
lipis added a commit that referenced this pull request Nov 12, 2019
@lipis
Merge branch 'master' of github.com:prettier/prettier into next
f7c772f 
* 'master' of github.com:prettier/prettier: (31 commits)
  Bump jest-watch-typeahead from 0.4.0 to 0.4.2 (#6923)
  Bump unified from 8.4.1 to 8.4.2 (#6927)
  refactoring: Babel's error recovery superseded option combinations (#6930)
  Update `fsevents` in yarn.lock (#6909)
  Run CI on the `next` branch
  Fix bin permissions (#6902)
  Add missing headings to changelog
  Fix code block in changelog
  Bump Prettier dependency to 1.19.1
  Release 1.19.1
  Quick-fix for stdin being broken in 1.19.0 (#6894)
  Fix `since` version for `vueIndentScriptAndStyle` (#6897)
  Remove out-of-date comment
  fix formatting of union type as arrow function return type (#6896)
  Try to fix some code blocks in 1.19.0 blog post
  Blog post, changelog and docs for 1.19 (#6787)
  Bump Prettier dependency to 1.19.0
  Release 1.19.0
  prettier 1.19.0-beta.1
  deduplicate entries in yarn.lock - part 2 (#6884)
  ...
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lydell lydell lydell left review comments

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yarn build doesn't make dist/bin-prettier.js executable anymore

2 participants

@fisker @lydell