Revert "Link to fast-glob instead of glob in docs (#6333)"#6721
Merged
lydell merged 1 commit intoprettier:masterfrom Nov 2, 2019
Merged
Revert "Link to fast-glob instead of glob in docs (#6333)"#6721lydell merged 1 commit intoprettier:masterfrom
fast-glob instead of glob in docs (#6333)"#6721lydell merged 1 commit intoprettier:masterfrom
Conversation
fisker
changed the title
fast-glob instead of glob in docs (#6333)"
|
After another look at PR #6333, I am not 100% convinced reverting it is 100% what we want. The point of PR #6333 is that the document referred to the glob syntax from node-glob, while we are now using whatever glob syntax is supported by globby. I think we also do not want to point to the README on the master branch of the globby project, since its readme now refers to fast-glob. I wonder if we should point to something like https://github.com/sindresorhus/globby/blob/v6.1.0/readme.md#globbing-patterns until we are ready to use globby@10. Or maybe it is time to stop supporting old installations (Node.js 6 from GitHub) and use globby@latest? Food for thought. |
5 tasks
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #6333, fixes #6719
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨