Added expandDirectories option which is on by default. The nodir option is now also true by default. This means that by default it will now only return file paths, not directory paths. cf55e5c

Looks like breaking changem try to use . pattern

Sounds like we need to add some tests, then.

I have a few more questions:

• Any explanation for the small loss of code coverage?
• Could this resolve support dot pattern for CLI #6085?
• Should we consider using globby@10 if we do not support install from GitHub on Node.js 6?

I was trying to make tests the another day, then I got distracted by #6665 .

Those options are really confusing me, as I understand,

nodir means donot list dirname , since we are looking for file we should use default true

expandDirectories also means that?

I think part of the confusion is how much globby has changed over quite a few major versions. I think we should try to research and understand this carefully before making any more adjustments. I do think we should also avoid using any options not really needed.

I am now really thinking we should consider using the latest rather than trying to deal with the old, unsupported package versions.

Unfortunately I don't have much time to look into this right now.

I tried raising RFC PR #6748 to try globby@10 update for discussion, seems to be mostly working with a few TODO items. I think that nodir setting is not needed in some newer versions of globby, removing it does not cause any failures. I am also thinking that expandDirectories should not be an issue since Prettier only works with files. But I may prove to be mistaken here.

closing in favor of #6748

closing in favor of #6748

Any ideas how we can resolve the TODO items in PR #6748?

@lydell @evilebottnawi @brodybits

I reopened this, and add dot pattern and expandDirectories tests.

This will not breaking anything, but support prettier . and prettier src, we can safely add this to v1.19

@lydell

If I understand currectly, what do you want is
prettier . --write
prettier dir/ --write
prettier . --list
prettier dir/ --list
not print UndefinedParserError

and
prettier **/* --write
prettier dir/**/* --write
prettier **/* --list
prettier dir/**/* --list

print UndefinedParserError (currently behavior)

is that currect?

Yes, that’s correct!

1. prettier dir1 dir2
2. prettier dir1 dir2/**/*
3. prettier non-exists-dir dir2/**/*
4. prettier . dir2/**/*

Can you explain to me, what those 4 should be?

1. prettier dir1 dir2 – prettify all files with supported extensions inside dir1 and dir2.
2. prettier dir1 dir2/**/* – prettify all files with supported extensions inside dir1 as well as all files matched by the dir2/**/* glob. If any of the latter files have unknown extensions – log an error for them.
3. prettier non-exists-dir dir2/**/* – log an error that non-exists-dir resulted in 0 files and prettify all files matched by the dir2/**/* glob. If any of the latter files have unknown extensions – log an error for them.
4. prettier . dir2/**/* – prettify all files with supported extensions in . and all files matched by the dir2/**/* glob. If any of the latter files have unknown extensions – log an error for them.

I basically want the same behavior as eslint.

just to clearify not supported extensions, because parser can be override by config.

For every file we go through, try to resolve the final config to use for that file like we already do. If parser is missing, throw an error if the file came from a full path or glob, and ignore the file if it came from a folder pattern. If a pattern (item in process.argv) results in 0 files (non-existent folder, empty folder, folder with no supported files, glob that does not match anything, non-existent file), warn about it resulting in 0 files.

For every file we go through, try to resolve the final config to use for that file like we already do.
[...]

Shouldn't this already be covered by the test suite?

If not, I think we should add the missing tests.

I've disabled all the behavior changes, it's only package upgrade now.

Also don't forget what plugins can add own extensions and it should be tested also (when we implement . support)

@fisker please fix conflicts and let's do it for next

@prettier/core please review

Rebased & CI passed.

What are we going to do with this one?

@fisker If we can't update globby to latest we need merge this branch

Closing in favor of #6776