Skip to content

feat: add new parser babel-ts to parse TypeScript syntaxes via Babel#6400

Merged
thorn0 merged 21 commits intoprettier:nextfrom
JounQin:feat/babel_ts
Jan 29, 2020
Merged

feat: add new parser babel-ts to parse TypeScript syntaxes via Babel#6400
thorn0 merged 21 commits intoprettier:nextfrom
JounQin:feat/babel_ts

Conversation

@JounQin
Copy link
Copy Markdown
Member

@JounQin JounQin commented Aug 18, 2019 •
edited
Loading

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

Motivation: Babel itself is able to parse TypeScript, but we haven't enabled it, which makes something like babel-preset-proposal-typescript can not integrate with Prettier perfectly, but it should be easy to support it.

j-f1
j-f1 requested changes Aug 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some more thorough tests (i.e. by adding the babel-ts parser to a few existing TypeScript test cases) to make sure that the printer can handle the Babel-TypeScript AST just as well as the ESTree-Typescript AST?

Comment thread docs/options.md Outdated
Comment thread docs/options.md Outdated
@JounQin
Copy link
Copy Markdown
Member Author

JounQin commented Aug 18, 2019

Can you add some more thorough tests (i.e. by adding the babel-ts parser to a few existing TypeScript test cases) to make sure that the printer can handle the Babel-TypeScript AST just as well as the ESTree-Typescript AST?

Done.

alexander-akait
alexander-akait reviewed Aug 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need 2 parsers for typescript

@JounQin
Copy link
Copy Markdown
Member Author

JounQin commented Aug 19, 2019 •
edited
Loading

Not sure we need 2 parsers for typescript

@evilebottnawi With babel-ts we will be able to integrate something like babel-preset-proposal-typescript as like in my PR description.

And we do have two parsers for flow. :)

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Aug 20, 2019

@JounQin 👍

@JounQin

This comment has been minimized.

Sign in to view
@alexander-akait

This comment has been minimized.

Sign in to view
@JounQin

This comment has been minimized.

Sign in to view
@JounQin

This comment has been minimized.

Sign in to view
@alexander-akait

This comment has been minimized.

Sign in to view
@JounQin

This comment has been minimized.

Sign in to view
@alexander-akait

This comment has been minimized.

Sign in to view
@JounQin

This comment has been minimized.

Sign in to view
@alexander-akait alexander-akait added this to the 1.19 milestone Sep 12, 2019
@alexander-akait

This comment has been minimized.

Sign in to view
@alexander-akait

This comment has been minimized.

Sign in to view
duailibe
duailibe requested changes Sep 25, 2019
View reviewed changes
Comment thread src/language-js/parser-babylon.js Outdated
@lipis

This comment has been minimized.

Sign in to view
@JounQin

This comment has been minimized.

Sign in to view
@alexander-akait

This comment has been minimized.

Sign in to view
@alexander-akait alexander-akait mentioned this pull request Sep 30, 2019
Closed
@alexander-akait

This comment has been minimized.

Sign in to view
@JounQin

This comment has been minimized.

Sign in to view
dasa
dasa reviewed Oct 1, 2019
View reviewed changes
Comment thread docs/options.md Outdated
@JounQin
Copy link
Copy Markdown
Member Author

JounQin commented Oct 2, 2019 •
edited by lipis
Loading

@duailibe Can you approve this PR? So that we merge it...

@alexander-akait alexander-akait mentioned this pull request Oct 2, 2019
Closed
@duailibe
Copy link
Copy Markdown
Collaborator

duailibe commented Oct 2, 2019

@JounQin I'm aware. I still disagree with the combinations, there are still too many

I'm trying to fix it myself, and I'll update the PR today

@thorn0
Copy link
Copy Markdown
Member

thorn0 commented Jan 23, 2020

Tested --parser babel-ts on the following repos: Microsoft/TypeScript, ReactiveX/rxjs, and angular/angular. The results are identical to formatting with --parser typescript. Does anyone want to help with this and test it on some big TypeScript codebases? Remember that it can be installed directly from GitHub with yarn add JounQin/prettier#feat/babel_ts.

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Jan 23, 2020

@thorn0 I think we if we find some problems we can send a PR with fix, it is not easy to find all edge cases

@thorn0 thorn0 requested a review from sosukesuzuki January 23, 2020 16:13
alexander-akait
alexander-akait approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge ⭐

JounQin and others added 21 commits January 29, 2020 13:41
@JounQin @thorn0
feat: add new parser babel-ts to parse TypeScript syntaxes via Babel
9f350f8
@JounQin @thorn0
docs: document parser babel-ts
cf6c5ee
@JounQin @thorn0
chore: enable babel-ts in markdown and worker.js
26554b4
@thorn0
verify all TS tests against babel-ts except disabled by disableBabelTS
bb70a15
@thorn0
simplify babel options combinations
5f6931c
@thorn0
support for TSDeclareMethod; fix abstract properties and methods
caf30ce
@thorn0
fix embedded angular templates and styles
eade1bf
@thorn0
fix TSImportType
ae789e3
@thorn0
fix method decorators
100a2fd
@thorn0
fix ranges
7eed9fe
@thorn0
work around loc inconsistencies for SequenceExpression
a94eb5b
@thorn0
don't print trailing comma in type parameters (unsupported in TS < 3.3)
7bc8aeb
@thorn0
preserve quotes for class properties
844fb8c
@thorn0
align printing of single-parameter functions
8041676
@thorn0
fix comments in degenerate single-element unions and intersections
8a4b333
@thorn0
fix comments for methods
b8b81bd
@thorn0
fix comments for mapped types
e270222
@thorn0
edit docs, change 'since' to 2.0.0
982f855
@thorn0
add changelog
afa2003
@thorn0
fix code sample on playground
13198fd
@thorn0
update snapshots after rebase
0af0418
@thorn0 thorn0 merged commit c1937cb into prettier:next Jan 29, 2020
@JounQin JounQin deleted the feat/babel_ts branch January 29, 2020 12:13
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label May 5, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thorn0 thorn0 thorn0 left review comments

@fisker fisker fisker left review comments

@lipis lipis lipis approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@j-f1 j-f1 Awaiting requested review from j-f1

@duailibe duailibe Awaiting requested review from duailibe

+2 more reviewers

@dasa dasa dasa left review comments

@lppedd lppedd lppedd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.