-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: format JSX Fragment correctly, consider Fragment as block #6398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@evilebottnawi @ikatyang I have no idea why babel parser throws, and Besides, the error come from
|
|
You could try changing that section to this: if (error.loc) {
throw createError(
// babel error prints (l:c) with cols that are zero indexed
// so we need our custom error
error.message.replace(/ \(.*\)/, ""),
{
start: {
line: error.loc.line,
column: error.loc.column + 1
}
}
);
} else {
throw error;
}That should show you the real error that’s causing the crash. |
|
It seems |
|
@j-f1 The tests have been fixed, would you like to review again? |
|
@evilebottnawi @ikatyang Please help to review. |
|
Sorry, i am not familiar with mdx, i can't review |
|
I'm not really familiar with MDX too albeit I learnt a lot about it today. =) |
|
@evilebottnawi @ikatyang @thorn0 This PR becomes much cleaner and easier for reviewing after #6949 been merged, thanks for @thorn0's great work. Please help to review it. |
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨