Skip to content

Conversation

@octogonz
Copy link

See this discussion: #6280

@octogonz octogonz changed the title Update cli.md to show how to fix /all/ files Update cli.md to explain how to fix all files Jul 10, 2019
@alexander-akait
Copy link
Member

alexander-akait commented Jul 10, 2019

This solution works for dot files like ".myconfig.js"?

@kachkaev
Copy link
Member

kachkaev commented Jul 10, 2019

IMHO suggesting people to use ** without explaining what should go into .prettierignore nearby will cause some confusion and result lots of extra issues in this repo. It took me a while to establish a sustainable structure for .prettierignore – this task was not trivial. All this glob stuff (**/* vs *.* vs * vs !*.blah) is pretty hard-core.

Also it is necessary to ensure that prettier --write "**" behaves in cmd.exe or PowerShell equally well before advising to use this trick.

@octogonz
Copy link
Author

Also it is necessary to ensure that prettier --write "**" behaves in cmd.exe or PowerShell equally well before advising to use this trick.

The ** is a itignore expression that I believe is processed by the ignore library, not by the OS shell. (The quotes disable shell expansion.) Thus it should be the same on every platform.

@kachkaev
Copy link
Member

I believe so too, I'm just saying that it would be cool to manually verify this 🙂

@octogonz
Copy link
Author

IMHO suggesting people to use ** without explaining what should go into .prettierignore nearby will cause some confusion and result lots of extra issues in this repo.

@kachkaev I'm going to reopen #6280, since it sounds like we haven't fully answered the question of "How do I use the CLI to fix all files?" We can resume the discussion there.

@thorn0
Copy link
Member

thorn0 commented Feb 25, 2020

Superseded by #7660

@thorn0 thorn0 closed this Feb 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants