[TypeScript] Add trailing comma for only arrow functions in tsx. #6190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sorry, this bug is cause by my mistake. Also, this feature does not happen on playground. I want somebody to check this on local environment. |
thorn0
reviewed
Jun 7, 2019
src/language-js/printer-estree.js
Outdated
| parent.params && | ||
| parent.params.length === 1 && | ||
| options.filepath && | ||
| options.filepath.match(/\.tsx/) && |
Member
There was a problem hiding this comment.
While you're at it, please improve this regexp a bit: /\.tsx$/i
Also it's better to rewrite the last two lines using test: /\.tsx$/i.test(options.filepath)
Collaborator
@sosukesuzuki Don't worry about that! It's my fault that I didn't see that could happen |
duailibe
approved these changes
Jun 7, 2019
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6189 .
Prettier inserts a trailing comma to single type parameter for arrow functions in tsx, since v 1.18 (#6115 ). But, this feature inserts a trailing comma to type parameter for besides arrow functions too (e.g, function , interface ).
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨