Nice!

• So if you want to format all files Prettier is capable of handling in your project you can run just prettier --write .?
• If you don't want Prettier to format .html files, you could add *.html to .prettierignore.
• If you've taught Prettier how to handle other files/extensions in .prettierrc you have to list them manually. For example: prettier --write . .prettierrc "**/*.hehe". I guess this isn't super common.

{
  "overrides": [
    {
      "files": ".prettierrc",
      "options": { "parser": "json" }
    },
    {
      "files": "*.hehe",
      "options": {
        "parser": "html"
      }
    }
  ]
}

@lydell I'm not sure those were questions but the answers are:

1. Yes! prettier --write **/** will still run in all files, regardless of their extensions
2. Yes. I've thought about this and I think it's worth discussing after this PR lands. This is what config file doesn't work at the way other libraries do #2691 is asking
3. Yes. That could also be fixed with the above (i.e. if we added a extensions: [] config)

There's still something missing: match files by their filenames instead of their extensions. Luckily globby has an option for that.

I'll see how that goes tomorrow morning.

Memory leak 😔

Hi @duailibe 👋

I'm quite busy these days so won't be able to dive in, sorry for that. Perhaps @arcanis could help here? The situation when there is no node_modules is somewhat related to #5819, which he worked on.

Hey! Unfortunately I'm afraid I won't have much resources to spend on this anytime soon 😕

@kachkaev Actually I'm more concerned about not erroring anymore, but that's okay :-)

@arcanis Don't worry about it!

So I ditched globby and wrote a little custom file finder. Obviously this is a breaking change I also included a change that this doesn't support negate patterns anymore, i.e. prettier --write foo/ !foo/bar/

We can continue to support it, but it was easier to drop and I judged this suits better in .prettierignore.

@lydell what happens now is:

• if you pass prettier --write 'foo/' it will only try to format supported files
• if you pass prettier --write 'foo/**' it will try to format all files and will show that error on the unsupported files 🤷‍♂

@duailibe what is blocker? I think we should use same behavior as in eslint to better DX, i can investigate and put here information about how it is works in eslint

@evilebottnawi not much.. we just need to iron everything out.

Also, this is a breaking change, so this will be in Prettier 2.0

Is there a way support for . in particular could be added without it being a breaking change, as a special case? Would you consider such a PR for a minor release?

/cc @lydell we can't move this to old 2.0, it is very important and it is breaking change, we should do this for 2.0

By “stretch” I meant “stretch goals.” If we have time we can do it. (Related: I have a new idea for the CLI/API that I’ll make an issue for soon.)

@lydell unfortunately we cannot stretch this issue because it is really a big change and important, i can take care

Of course we can wait doing this. Time’s up for making a breaking change. We literally can’t push 2.0 any longer into the future because supporting old Node.js undermines the whole project. So we can’t have 2.0 depend on this feature, because it is not super easy to do. But if you manage to do it before January that would of course be super awesome!

@lydell it is easy, i will send a PR at end of month ⭐

Can we release this in 2.0? postpone to 3.0?

@sosukesuzuki Yes we can, need continue work 😄 You can be champion

@evilebottnawi Okay, I'll work on this.

/cc @fisker Can you help with this? I think we need open a new PR, graceful for help

@evilebottnawi It seems I don't have too much time in next few days, and this seems a little tricky, may need more time.

Are we going to ship in v2?

@fisker yes, because it is will big breaking change and the next major version (3.0) will not be soon, so we should ship it for 2.0, don't worry, our release will not on this week

@evilebottnawi I'm sorry but I'm not be able to work on this, my wife is having a baby. Someone please take over.

@fisker Wow, that sounds like quite a long-term project. Please have a look at #7660 when you have a minute.

Superseded by #7660