Skip to content

fix: allow plugin instance (#5760)#5763

Merged
duailibe merged 2 commits intoprettier:masterfrom
Kingwl:allow_plugin_instance
Jan 18, 2019
Merged

fix: allow plugin instance (#5760)#5763
duailibe merged 2 commits intoprettier:masterfrom
Kingwl:allow_plugin_instance

Conversation

@Kingwl
Copy link
Copy Markdown
Contributor

@Kingwl Kingwl commented Jan 17, 2019

Fixes #5760

  • I’ve added tests to confirm my change works. ?
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Jan 17, 2019

#5760

@alexander-akait
Copy link
Copy Markdown
Member

Need tests

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Jan 17, 2019

I am not sure how to add this test.

@Kingwl Kingwl force-pushed the allow_plugin_instance branch from 2c4be65 to d275528 Compare January 17, 2019 16:08
@alexander-akait
Copy link
Copy Markdown
Member

@Kingwl Kingwl force-pushed the allow_plugin_instance branch from d275528 to 08b0b13 Compare January 17, 2019 17:35
@ikatyang ikatyang self-requested a review January 18, 2019 02:03
Comment thread src/common/load-plugins.js Outdated
Comment thread tests_integration/__tests__/format.js Outdated
@Kingwl Kingwl force-pushed the allow_plugin_instance branch from 08b0b13 to 95e05f2 Compare January 18, 2019 10:13
@ikatyang ikatyang added this to the 1.16 milestone Jan 18, 2019
@duailibe duailibe merged commit 1dea4ef into prettier:master Jan 18, 2019
ikatyang added a commit to ikatyang/prettier that referenced this pull request Jan 18, 2019
@Kingwl Kingwl deleted the allow_plugin_instance branch January 18, 2019 16:07
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 18, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins options support plugin instance too

4 participants