Skip to content

Conversation

@ikatyang
Copy link
Member

@ikatyang ikatyang commented Dec 8, 2018

  • upload coverage report (codecov) from azure pipelines
  • only build dist once (dist is now shared between production jobs)
  • run production tests on macOS (not sure why but it's faster than others)
  • extract shareable steps
  • remove travis/circle

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added the status:wip Pull requests that are a work in progress and should not be merged label Dec 8, 2018
@ikatyang
Copy link
Member Author

I guess we could use the official codecov branch for now since I'm not sure when will the next version be released.

@ikatyang ikatyang removed the status:wip Pull requests that are a work in progress and should not be merged label Dec 16, 2018
@ikatyang ikatyang merged commit f94f63b into prettier:master Dec 18, 2018
@ikatyang ikatyang deleted the chore/update-azure-pipelines branch December 18, 2018 00:16
@kachkaev
Copy link
Member

kachkaev commented Dec 22, 2018

Thanks for working on integrating Azure Pipelines @ikatyang! I use them at work, so decided to give them a go in the prettier-plugin-elm repo. Dropping Travis, AppVeyor and Code Climate with all their clumsy integrations is such a relief! 🎉

Feel free to check out how I organised the yamls and borrow some stuff back if you want. One thing you may be interested in would be an extension called Build Quality Checks. It fails the build if the reported coverage value is smaller than a threshold or a previously known value.

One more thing to spread the word about: Starting from today, prettier-plugin-elm is the first Prettier plugin I know of that is written in TypeScript 🕺

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Mar 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants