Skip to content

fix(markdown): do not keep increasing backslashes for dollar sign #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ikatyang merged 3 commits into from
Nov 7, 2018
Merged

fix(markdown): do not keep increasing backslashes for dollar sign #5358

ikatyang merged 3 commits into from
Nov 7, 2018

Conversation

@ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 7, 2018 •
edited
Loading

Fixes #5359

We should add some tests for second formatting..

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.1 milestone Nov 7, 2018
@ikatyang ikatyang added priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! and removed priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! labels Nov 7, 2018
@ikatyang ikatyang merged commit 8cedb9d into prettier:master Nov 7, 2018
@ikatyang ikatyang deleted the fix/markdown/dollar-sign branch November 7, 2018 02:07
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15.1

Development

Successfully merging this pull request may close these issues.

1 participant

@ikatyang