Skip to content

fix(jsx): do not move trailing char to the next line as leading char#5354

Merged
ikatyang merged 3 commits intoprettier:masterfrom
ikatyang:fix/jsx/jsx-line-break
Nov 6, 2018
Merged

fix(jsx): do not move trailing char to the next line as leading char#5354
ikatyang merged 3 commits intoprettier:masterfrom
ikatyang:fix/jsx/jsx-line-break

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Nov 6, 2018

Fixes #5336

Though I'm not sure why we should special-case self-closing tags, the changes look OK to me.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang merged commit a4e8aaf into prettier:master Nov 6, 2018
@ikatyang ikatyang deleted the fix/jsx/jsx-line-break branch November 6, 2018 23:41
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 5, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants