Update rationale for the 1.15 changes#5332
Merged
ikatyang merged 6 commits intoprettier:masterfrom Nov 7, 2018
Merged
Conversation
lipis
approved these changes
Nov 4, 2018
j-f1
approved these changes
Nov 4, 2018
Member
j-f1
left a comment
j-f1
left a comment
There was a problem hiding this comment.
Looks like there are some linting issues.
Collaborator
|
If you're going to talk about exporting decorated classes, you might want to also mention that the proposal has not yet decided which if either position ultimately be legal. That's I think a separate issue from the question of whether to put a linebreak in. |
Member
|
Great work, thanks! |
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged when 1.15 has been released and we've updated our own Prettier version.