Skip to content

Update flow parser to 0.84.0#5303

Merged
ikatyang merged 1 commit intoprettier:masterfrom
jbrown215:update_flow_parser
Oct 26, 2018
Merged

Update flow parser to 0.84.0#5303
ikatyang merged 1 commit intoprettier:masterfrom
jbrown215:update_flow_parser

Conversation

@jbrown215
Copy link
Copy Markdown
Contributor

@jbrown215 jbrown215 commented Oct 25, 2018

Fixes #5084

Update the flow parser to 0.84.0, which includes parser support for explicit inexact objects using .... See https://medium.com/flow-type/on-the-roadmap-exact-objects-by-default-16b72933c5cf for more info.

One test had to be re-recorded

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@jbrown215 jbrown215 mentioned this pull request Oct 25, 2018
2 tasks
Copy link
Copy Markdown
Member

@lydell lydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so excited for the upcoming exact-by-default Flow versions now! 🎉

This looks good to me. Just have a minor question about the changed snapshot.

Comment thread tests/es6modules/__snapshots__/jsfmt.spec.js.snap
@lydell lydell added this to the 1.15 milestone Oct 26, 2018
@ikatyang ikatyang merged commit 5d47e02 into prettier:master Oct 26, 2018
@ikatyang
Copy link
Copy Markdown
Member

Thanks!

ikatyang added a commit to ikatyang/prettier that referenced this pull request Oct 26, 2018
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 24, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants