Skip to content

docs(blog): 1.15 release#5296

Merged
ikatyang merged 104 commits intoprettier:masterfrom
ikatyang:docs/blog-1.15
Nov 7, 2018
Merged

docs(blog): 1.15 release#5296
ikatyang merged 104 commits intoprettier:masterfrom
ikatyang:docs/blog-1.15

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Oct 25, 2018 •
edited
Loading

There're 50+ items in this release, it'd be appreciated if somebody could pick some of them up.

Feel free to edit this PR directly.

🌟 Live preview 🌟

@ikatyang ikatyang added the status:wip Pull requests that are a work in progress and should not be merged label Oct 25, 2018
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@ikatyang ikatyang mentioned this pull request Oct 25, 2018
Closed
11 tasks
j-f1
j-f1 reviewed Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll help write some descriptions. A few comments:

Comment thread README.md Outdated
Comment thread docs/options.md

## HTML Whitespace Sensitivity

_available in v1.15.0+_
Copy link
Copy Markdown
Member

@j-f1 j-f1 Oct 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these should be formatted differently (grammar-wise)? Perhaps:

First available in vX.X.X. Deprecated in vY.Y.Y

Copy link
Copy Markdown
Member Author

@ikatyang ikatyang Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's a +, I guess it should be fine?

@lipis
Copy link
Copy Markdown
Member

lipis commented Oct 26, 2018

https://github.com/ikatyang/prettier/pull/2/files

@ikatyang
Copy link
Copy Markdown
Member Author

ikatyang commented Oct 26, 2018

You can edit this PR directly, I've checked Allow edits from maintainers..

@lipis
Copy link
Copy Markdown
Member

lipis commented Oct 26, 2018

Thanks @ikatyang.. I was experimenting.. :)

@lipis
Copy link
Copy Markdown
Member

lipis commented Oct 26, 2018

Maybe grouping the languages? https://github.com/prettier/prettier/blob/b944ad58eed30d0dc7abc347e744dbfbe919891d/README.md#opinionated-code-formatter

lipis
lipis approved these changes Nov 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful :) But I guess we should merge this after the release.

@ikatyang
Copy link
Copy Markdown
Member Author

ikatyang commented Nov 4, 2018

Sure. In the last release, I merged the blog post before the release, which results in no new version available on npm for 12 min. 😂

@ikatyang ikatyang changed the title docs(blog): 1.15 release draft docs(blog): 1.15 release Nov 4, 2018
@lipis
Copy link
Copy Markdown
Member

lipis commented Nov 4, 2018

It looks like we will have to add this one as well: #5327 :)

@suchipi
Copy link
Copy Markdown
Member

suchipi commented Nov 5, 2018

I went through and revised wording here and there.

Thanks for driving this release and everything for the last few months, @ikatyang and everyone!

suchipi and others added 2 commits November 4, 2018 20:22
@suchipi
Fix prettier issue
21ef4a1 
Guess I don't have my editor setup right on this computer 😅
@ikatyang
docs: update thanks
90beb63
@lydell
Copy link
Copy Markdown
Member

lydell commented Nov 5, 2018

@lipis It might be better to hold off on that PR to the next release.

@lipis
Copy link
Copy Markdown
Member

lipis commented Nov 5, 2018

@lydell Just comment on the original issue.. we didn't add the 1.15 milestone to it anyway.

existentialism
existentialism approved these changes Nov 6, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a few small typos, but awesome work!

@ikatyang ikatyang merged commit fa40f2d into prettier:master Nov 7, 2018
@ikatyang ikatyang deleted the docs/blog-1.15 branch November 7, 2018 01:09
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 5, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lydell lydell lydell left review comments

@existentialism existentialism existentialism approved these changes

@lipis lipis lipis approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

7 participants

@ikatyang @lipis @alexw10 @j-f1 @suchipi @lydell @existentialism