Fixed unstable while comment#5251
Merged
j-f1 merged 3 commits intoprettier:masterfrom Oct 25, 2018
Merged
Conversation
j-f1
approved these changes
Oct 13, 2018
lydell
approved these changes
Oct 25, 2018
Member
|
Thanks for contributing! |
ikatyang
added a commit
to ikatyang/prettier
that referenced
this pull request
Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an Issues with unstable comments inside a while condition (described in #5245 ) by adding a handler function that applies only while loops that checks if a comment is before the end of the condition then maintains the trailing comment after the Boolean expression
I also made the formatting of comments on while loops more similar to if statements as referenced in the Issue thread
Fixes #5245.
docs/directory)