fix(markdown): do not add whitespaces between Latin and Hangul#5040
Merged
ikatyang merged 9 commits intoprettier:masterfrom Sep 2, 2018
Merged
fix(markdown): do not add whitespaces between Latin and Hangul#5040ikatyang merged 9 commits intoprettier:masterfrom
ikatyang merged 9 commits intoprettier:masterfrom
Conversation
suchipi
reviewed
Sep 1, 2018
| } | ||
|
|
||
| const json = JSON.stringify( | ||
| require(id.replace(/^\0commonjs-proxy:/, "")), |
Member
There was a problem hiding this comment.
Where does this \0commonjs-proxy: come from?
Member
Author
There was a problem hiding this comment.
rollup-plugin-commonjs I guess?
suchipi
approved these changes
Sep 1, 2018
j-f1
reviewed
Sep 1, 2018
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`cjk.md - markdown-verify 1`] = ` | ||
| exports[`cj.md - markdown-verify 1`] = ` |
Member
There was a problem hiding this comment.
What do you think about renaming these to chinese-japanese.md and korean.md so it’s clearer at first glance what they’re testing?
Or are cj and k common abbreviations?
Member
There was a problem hiding this comment.
I've seen CJK, but never CJ and K as separate abbreviations
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5028
Based on #5028 (comment), it seems Korean text uses conventional space so we're not going to add whitespaces between Latin and Hangul.
Prettier pr-5040
Playground link
Input:
Output:
docs/directory)