refactor: extract options-normalizer/validator#5020
Merged
ikatyang merged 3 commits intoprettier:masterfrom Aug 31, 2018
Merged
refactor: extract options-normalizer/validator#5020ikatyang merged 3 commits intoprettier:masterfrom
ikatyang merged 3 commits intoprettier:masterfrom
Conversation
ikatyang
commented
Aug 28, 2018
|
|
||
| exports[`throw error with invalid config option (trailingComma) (stderr) 1`] = ` | ||
| "[error] Invalid \`\\"trailingComma\\"\` value. Expected \\"all\\", \\"es5\\" or \\"none\\", but received \`\\"wow\\"\`. | ||
| "[error] Invalid trailingComma value. Expected \\"all\\", \\"es5\\" or \\"none\\", but received \\"wow\\". |
suchipi
reviewed
Aug 28, 2018
|
|
||
| exports[`deprecated option values are warned (stderr) 1`] = ` | ||
| "[warn] \`--trailing-comma\` without an argument is deprecated. Prettier now treats it as \`--trailing-comma=es5\`. | ||
| "[warn] --trailing-comma without an argument is deprecated, now treats it as --trailing-comma=es5. |
Member
There was a problem hiding this comment.
"now treats it" without a subject isn't valid; maybe we should say "this is treated as"? It's passive voice but... I think it's clearer
Member
Author
There was a problem hiding this comment.
How about we now treat it as ...?
Contributor
There was a problem hiding this comment.
May I do a drive-by interjection about comma splices? That should be "... deprecated; we now treat it as", rather than separated by a semicolon.
suchipi
approved these changes
Aug 30, 2018
Contributor
|
Thanks @ikatyang! |
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vnoptsforward, e.g.singleQuote: true->"javascript/singleQuote": "js",singleQuote: false->"javascript/singleQuote": "none".docs/directory)