[flow] Fix union indent inside of function param with a name#4325
Merged
vjeux merged 1 commit intoprettier:masterfrom Apr 17, 2018
Merged
[flow] Fix union indent inside of function param with a name#4325vjeux merged 1 commit intoprettier:masterfrom
vjeux merged 1 commit intoprettier:masterfrom
Conversation
Fixes prettier#4323 See prettier#4323 for all the context
j-f1
reviewed
Apr 16, 2018
| append( | ||
| options?: | ||
| | string | ||
| | { |
Member
There was a problem hiding this comment.
Would this look better as options?: string | {?
Contributor
Author
There was a problem hiding this comment.
If I remember correctly, I only do the printing for undefined and null. We could extend it. I wanted to err on the safe side.
existentialism
approved these changes
Apr 17, 2018
Contributor
Author
|
@suchipi: would you be able to cut 1.12.1 with this change by any chance? I really want to get the new release out to Facebook :p |
Member
|
@vjeux can do |
Member
|
@vjeux 1.12.1 is released |
Member
|
yay! |
Contributor
Author
|
@suchipi thanks so much for the quick turnaround time! |
Member
|
You're welcome 😃 |
This was referenced Apr 17, 2018
This was referenced Apr 26, 2018
This was referenced May 16, 2018
This was referenced May 24, 2018
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4323
See #4323 for all the context.
I'd love to get it merged and ship a dot release if possible with it. It's affecting a bunch of code and prevents upgrading to the latest version of prettier at Facebook. I know it's been there for a while (since 1.9.3...)