Skip to content

Wrap awaits in unary expressions with parens#4315

Merged
j-f1 merged 1 commit intoprettier:masterfrom
ZachGawlik:parens-negate-async
Apr 14, 2018
Merged

Wrap awaits in unary expressions with parens#4315
j-f1 merged 1 commit intoprettier:masterfrom
ZachGawlik:parens-negate-async

Conversation

@ZachGawlik
Copy link
Copy Markdown
Contributor

@ZachGawlik ZachGawlik commented Apr 14, 2018 •
edited
Loading

Fixes #4138 by wrapping await expressions inside of unary expressions. (list of unary operators)

Sample input (currently prettier would leave this unchanged):

const w = !await resolveIdentity(false);
const x = -await resolveIdentity(3);
const y = +await resolveIdentity('3');
const z = typeof await resolveIdentity(false);

Output:

const w = !(await resolveIdentity(false));
const x = -(await resolveIdentity(3));
const y = +(await resolveIdentity('3'));
const z = typeof (await resolveIdentity(false));

j-f1
j-f1 approved these changes Apr 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@j-f1 j-f1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite a bit clearer 👍

lydell
lydell approved these changes Apr 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@lydell lydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this too!

@j-f1 j-f1 merged commit 0a22f5e into prettier:master Apr 14, 2018
@j-f1
Copy link
Copy Markdown
Member

j-f1 commented Apr 14, 2018

Thanks!

@renovate renovate Bot mentioned this pull request Apr 17, 2018
Merged
This was referenced Apr 17, 2018
Merged
Closed
Closed
Closed
Closed
This was referenced Apr 26, 2018
Closed
Closed
This was referenced May 16, 2018
Closed
Open
Closed
Open
Closed
Open
This was referenced May 24, 2018
Open
Open
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 13, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@suchipi suchipi suchipi approved these changes

@lydell lydell lydell approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

negate async function result will break in safari 11

4 participants

@ZachGawlik @j-f1 @suchipi @lydell