Skip to content

Bump own prettier dependency version to 1.11.0#4058

Merged
suchipi merged 1 commit intomasterfrom
bump_own_prettier_dep_to_1_11_0
Feb 27, 2018
Merged

Bump own prettier dependency version to 1.11.0#4058
suchipi merged 1 commit intomasterfrom
bump_own_prettier_dep_to_1_11_0

Conversation

@suchipi
Copy link
Copy Markdown
Member

@suchipi suchipi commented Feb 27, 2018

1.11.0 has been released

#### Don't lowercase nesting selector ([#4048] by [@evilebottnawi])

In Prettier 1.10.2, we were incorrectly lower-casing nesting SCSS selectors:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These line breaks aren't actually new in 1.11.0, I just edited this via the GitHub editor, so it wasn't prettified.

Comment thread docs/vim.md
3. Use locally installed vim-prettier prettier executable
1. Traverse parents and search for Prettier installation inside `node_modules`
2. Look for a global prettier installation
3. Use locally installed vim-prettier prettier executable
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikatyang does this look right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the result from #3990.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suchipi suchipi force-pushed the bump_own_prettier_dep_to_1_11_0 branch from 29b784d to d0045b6 Compare February 27, 2018 01:50
@suchipi suchipi merged commit 74a132c into master Feb 27, 2018
@j-f1 j-f1 deleted the bump_own_prettier_dep_to_1_11_0 branch February 27, 2018 11:10
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 18, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants