Skip to content

fix: don't lowercase nesting selector#4048

Merged
suchipi merged 1 commit intomasterfrom
issue-241
Feb 27, 2018
Merged

fix: don't lowercase nesting selector#4048
suchipi merged 1 commit intomasterfrom
issue-241

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait commented Feb 26, 2018

fixes #4044

@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Feb 26, 2018

/cc @lydell @j-f1

@alexander-akait alexander-akait mentioned this pull request Feb 26, 2018
Closed
24 tasks
j-f1
j-f1 reviewed Feb 26, 2018
View reviewed changes
Comment thread tests/css_case/__snapshots__/jsfmt.spec.js.snap Outdated
}
&-KeepSelector & .KeepClassSelector {
}
&-100.200 {
Copy link
Copy Markdown
Member

@j-f1 j-f1 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this selector valid?

Copy link
Copy Markdown
Member Author

@alexander-akait alexander-akait Feb 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-f1 , i mean 100\.200 it is valid selector

Comment thread src/language-css/printer-postcss.js
}
case "selector-tag": {
const parentNode = path.getParentNode();
const index = parentNode && parentNode.nodes.indexOf(node);
Copy link
Copy Markdown
Member

@j-f1 j-f1 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can get this with path.getKey().

Copy link
Copy Markdown
Member Author

@alexander-akait alexander-akait Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-f1 I can't find path.getKey() in fast-path.js 😕

Copy link
Copy Markdown
Member

@j-f1 j-f1 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it’s getName. However, it always returns a string.

Copy link
Copy Markdown
Member Author

@alexander-akait alexander-akait Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-f1 we can't get name preview node without getting index current node, approve this PR?

Copy link
Copy Markdown
Member

@j-f1 j-f1 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilebottnawi I didn’t quite understand your comment; can you clarify please?

@azz azz added this to the 1.11 milestone Feb 26, 2018
@lipis lipis mentioned this pull request Feb 26, 2018
Merged
@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Feb 26, 2018

/cc @j-f1 feel free to merge, i can be inaccessible in the near future (1-2 days)

@suchipi suchipi merged commit 4ddf1a6 into master Feb 27, 2018
@j-f1 j-f1 deleted the issue-241 branch February 27, 2018 11:12
@renovate renovate Bot mentioned this pull request Mar 22, 2018
Merged
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 18, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@j-f1 j-f1 j-f1 left review comments

@lydell lydell lydell approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.11

Development

Successfully merging this pull request may close these issues.

[SCSS] Selector starting with & is lowercased

5 participants

@alexander-akait @lydell @j-f1 @azz @suchipi