1.11 Release Notes and Changelog by suchipi · Pull Request #4035 · prettier/prettier

suchipi · 2018-02-23T22:41:04Z

Here is the proposed Release Notes blog post and Changelog for the 1.11 release. Could someone please proofread it?

Rendered version here:
https://deploy-preview-4035--prettier.netlify.com/blog/2018/02/26/1.11.0.html

vjeux · 2018-02-23T23:42:32Z

Just read through it all, awesome job @suchipi writing the release notes, it's been really nice to read them through!

Also, omg @evilebottnawi you've been on fire!

suchipi · 2018-02-23T23:44:18Z

@vjeux Do you have reservations about releasing on a Friday evening? Should we wait until Monday?

suchipi · 2018-02-23T23:50:29Z

Ah thanks, forgot to announce that

lipis · 2018-02-23T23:51:02Z

We should mention Facebook's 100% #3931 (comment) and I thinks it's better to wait until Monday :)

vjeux · 2018-02-23T23:51:18Z

What we can do is to publish a pre-release now so people can try it out and release it on Monday for real? So we don't break everyone if we have some unforeseen issue

lipis · 2018-02-23T23:52:08Z

Already mentioned.. :) Shall we wait until Monday?

suchipi · 2018-02-23T23:53:52Z

I'll publish a prerelease via tag "next"

suchipi · 2018-02-23T23:54:17Z

(And let's wait to merge this PR until we do the real release)

lipis · 2018-02-24T00:02:26Z

+
+### Facebook is 💯% Prettier
+
+Another exciting announcement is that all the JavaScript files in the Facebook codebase have now been converted to prettier! What's mindblowing is that there hasn't been a concerted push to convert the codebase to prettier, we just added the tooling in place and documentation on how to migrate a folder to prettier and people just started converting their piece of the codebase.


prettier -> Prettier

suchipi · 2018-02-24T00:14:38Z

@lipis how do I tweet from the PrettierCode twitter account?

suchipi · 2018-02-24T00:22:14Z

Or @vjeux you can redo that tweet from your account if you want, either way is fine as far as I'm concerned

vjeux · 2018-02-24T00:24:13Z

https://twitter.com/Vjeux/status/967193354273308672

TrySound · 2018-02-24T00:43:28Z

+const abc = props.something
+	? xyz
+	: {
+			prop1: a,


Why 3 tabs here?

So that it's aligned when tabs are rendered as two spaces, I believe.

There's a lot of discussion about it here: #3745

lipis · 2018-02-24T00:56:54Z

@suchipi send me your Twitter account and I'll give you access..

suchipi · 2018-02-24T00:57:33Z

It's @suchipi :)

lipis · 2018-02-24T01:28:42Z

Will do it tomorrow.. not easy from mobile.. :)

lipis · 2018-02-24T15:19:08Z

+
+## Highlights
+
+### CSS/SCSS/LESS


LESS -> Less

j-f1 · 2018-02-26T11:47:32Z

 ### CSS/SCSS/Less

-#### Lists of lists now have prettier formatting ([#3930] by [@evilebottnawi])
+#### Lists of lists now have Prettier formatting ([#3930] by [@evilebottnawi])


This should still be prettier.

Sure.. but why?

The PR improved the formatting of lists of lists, but we already formatted them.

and that's why it should be written prettier instead of Prettier or am I missing something?

Yes that’s the reason.

I guess it’s because prettier = better here, it’s not a library name in this context.

might even be worth using a different adjective to avoid confusion:

"Lists of lists now have cleaner formatting"
"Lists of lists now have better formatting"

or something similar

Maybe ‘more consistent’ or just ‘consistent’? ‘Better’ is way too subjective IMO, yet ‘cleaner’ looks OK.

Agree about the confusion with `prettier’ here.

Now I realised why I was confused.. :)

Changed it to cleaner.. if anyone has a better one let me know.

suchipi · 2018-02-26T16:43:50Z

I'm busy at work today, if someone else is able to publish the release I'd appreciate it. Otherwise I'll do it this afternoon. The date on this should be changed from 2/23 to 2/26 before merge.

ericanderson · 2018-02-26T17:04:21Z

Can the release wait for #4052 ?

orta · 2018-02-26T17:10:38Z

Great work @suchipi

lipis · 2018-02-26T17:15:32Z

We need to update the post with the #4028 changes and with #4052 if it's going to make it to the release.

lipis · 2018-02-26T17:32:21Z

and #4048 it seems: https://github.com/prettier/prettier/milestone/15

ericanderson · 2018-02-26T19:27:07Z

#4052 doesn't need a changelog entry. It fixes a regression I caused in #4005

salemhilal · 2018-02-26T21:42:11Z

+}
+```
+
+### JavaScript


I'm not sure how granular you want to be with these release notes, but my define() tweak I thiiiink made it into this release: #3830

Thanks, I must have missed that one. I'll add an entry for it

Thank you, and thanks for all your hard work!

suchipi added 2 commits February 23, 2018 15:39

Add blog post with changelog

44a7df6

Add release notes link to CHANGELOG.md

692ef69

suchipi mentioned this pull request Feb 23, 2018

1.11 Release #3931

Closed

24 tasks

suchipi added 2 commits February 23, 2018 15:50

Fix typo in tab ternary fix code block

430c4d3

Fix an unfinished edit

ea7f71e

suchipi and others added 2 commits February 23, 2018 16:47

Add missing parens

2bd152c

Update 2018-02-23-1.11.0.md

af7783a

lipis reviewed Feb 24, 2018

View reviewed changes

suchipi mentioned this pull request Feb 24, 2018

Bump own prettier dependency version to 1.11.0-rc.1 #4036

Closed

Update 2018-02-23-1.11.0.md

e083c50

TrySound reviewed Feb 24, 2018

View reviewed changes

Add more release notes

2904f7f

lipis reviewed Feb 24, 2018

View reviewed changes

Comment thread website/blog/2018-02-23-1.11.0.md Outdated

## Highlights

### CSS/SCSS/LESS

Copy link
Copy Markdown

Member

lipis Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LESS -> Less

suchipi and others added 2 commits February 24, 2018 22:08

Update 2018-02-23-1.11.0.md

f16d55a

prettier -> Prettier

14e89fe

j-f1 requested changes Feb 26, 2018

View reviewed changes

lipis mentioned this pull request Feb 26, 2018

feat: ignore non standard IE filter values #4028

Merged

lipis added this to the 1.11 milestone Feb 26, 2018

j-f1 and others added 2 commits February 26, 2018 11:47

Update date

aa6b214

cleaner

173a872

j-f1 approved these changes Feb 26, 2018

View reviewed changes

casing

c1889eb

salemhilal reviewed Feb 26, 2018

View reviewed changes

suchipi added 4 commits February 26, 2018 17:59

Update CHANGELOG.md

4be9d0e

Update 2018-02-26-1.11.0.md

0c0d931

Update 2018-02-26-1.11.0.md

baf9f6e

Update 2018-02-26-1.11.0.md

ca94d36

suchipi merged commit b1b504f into prettier:master Feb 27, 2018

renovate Bot mentioned this pull request Mar 22, 2018

Update prettier to 1.12.1 sbardian/DebtTrackerAPI#28

Merged

kachkaev mentioned this pull request Apr 12, 2018

Code blocks in markdown list items with two or more empty lines may crash parser #4306

Closed

lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 18, 2019

lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019


		### Facebook is 💯% Prettier

		Another exciting announcement is that all the JavaScript files in the Facebook codebase have now been converted to prettier! What's mindblowing is that there hasn't been a concerted push to convert the codebase to prettier, we just added the tooling in place and documentation on how to migrate a folder to prettier and people just started converting their piece of the codebase.

Uh oh!

Conversation

suchipi commented Feb 23, 2018 • edited by lipis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vjeux commented Feb 23, 2018

Uh oh!

suchipi commented Feb 23, 2018

Uh oh!

suchipi commented Feb 23, 2018

Uh oh!

lipis commented Feb 23, 2018

Uh oh!

vjeux commented Feb 23, 2018

Uh oh!

lipis commented Feb 23, 2018

Uh oh!

suchipi commented Feb 23, 2018

Uh oh!

suchipi commented Feb 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suchipi commented Feb 24, 2018

Uh oh!

suchipi commented Feb 24, 2018

Uh oh!

vjeux commented Feb 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lipis commented Feb 24, 2018

Uh oh!

suchipi commented Feb 24, 2018

Uh oh!

lipis commented Feb 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suchipi commented Feb 26, 2018

Uh oh!

ericanderson commented Feb 26, 2018

Uh oh!

orta commented Feb 26, 2018

Uh oh!

lipis commented Feb 26, 2018

Uh oh!

lipis commented Feb 26, 2018

Uh oh!

ericanderson commented Feb 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

suchipi commented Feb 23, 2018 •

edited by lipis

Loading