Skip to content

feat: ignore non standard IE filter values#4028

Merged
alexander-akait merged 1 commit intomasterfrom
feat-ignore-non-standard-filter-progid-value
Feb 26, 2018
Merged

feat: ignore non standard IE filter values#4028
alexander-akait merged 1 commit intomasterfrom
feat-ignore-non-standard-filter-progid-value

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait commented Feb 22, 2018

Why?

  1. It is non standard.
  2. It is break standard css specification.
  3. Rare usage.
  4. Many logic around this = decrease perf
  5. I don't found right syntax.

In 7-8 IE (with newlines) don't work, in IE 9 work 😕

progid:DXImageTransform.Microsoft.gradient(
  enabled='false', 
  startColorstr='#fff', 
  endColorstr='#000'
);
  1. Very buggy property 😄

Let's output this property as is

j-f1
j-f1 requested changes Feb 22, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Feb 23, 2018

@j-f1 tests? We Already have tests around progid:

@j-f1
Copy link
Copy Markdown
Member

j-f1 commented Feb 23, 2018

Can you add some tests of things that are no longer broken across lines?

@alexander-akait alexander-akait force-pushed the feat-ignore-non-standard-filter-progid-value branch from fb90078 to 0570a59 Compare February 26, 2018 11:00
@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Feb 26, 2018

/cc @j-f1 @lydell

@alexander-akait alexander-akait force-pushed the feat-ignore-non-standard-filter-progid-value branch from 0570a59 to f860371 Compare February 26, 2018 11:27
@alexander-akait alexander-akait merged commit 65b988a into master Feb 26, 2018
@alexander-akait alexander-akait deleted the feat-ignore-non-standard-filter-progid-value branch February 26, 2018 11:58
@lipis
Copy link
Copy Markdown
Member

lipis commented Feb 26, 2018

We should update the release notes #4035

@lipis lipis added this to the 1.11 milestone Feb 26, 2018
@lipis lipis mentioned this pull request Feb 26, 2018
Merged
@renovate renovate Bot mentioned this pull request Mar 22, 2018
Merged
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 18, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lydell lydell lydell approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.11

Development

Successfully merging this pull request may close these issues.

4 participants

@alexander-akait @j-f1 @lipis @lydell