fix(typescript): properly chain when there is a TSNonNullExpression#4005
Merged
duailibe merged 4 commits intoprettier:masterfrom Feb 20, 2018
Merged
fix(typescript): properly chain when there is a TSNonNullExpression#4005duailibe merged 4 commits intoprettier:masterfrom
duailibe merged 4 commits intoprettier:masterfrom
Conversation
j-f1
reviewed
Feb 20, 2018
| return concat(["::", path.call(print, "callee")]); | ||
| } | ||
|
|
||
| function printNonNullExpression() { |
Contributor
Author
|
It seemed like when things were done more than once, they were abstracted. More than happy to just use a string literal. |
Member
|
I think that’s a better idea, given that this is just |
azz
approved these changes
Feb 20, 2018
Member
azz
left a comment
azz
left a comment
There was a problem hiding this comment.
I'd also prefer to inline "!" if there's only two occurrences. Otherwise lgtm!
duailibe
approved these changes
Feb 20, 2018
Collaborator
|
Thanks for contributing! 🎉 |
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3999
When encountering a
TSNonNullExpression, don't abort the chain. Just include it with the current group.