playground: add (s)css examples#3696
Merged
j-f1 merged 4 commits intoprettier:masterfrom Jan 10, 2018
Merged
Conversation
azz
approved these changes
Jan 10, 2018
Member
|
What's the license terms of bootstrap? (It probably doesn't matter here though? I don't know...) |
Contributor
Author
|
It's MIT, so I'm not 100% sure if this is allowed without license text. It's such a small block that it doesn't matter I guess though 🤔 https://getbootstrap.com/docs/4.0/about/license/ |
Member
|
Yeah I really don't think it matters for tiny extracts. I guess you could put a comment in the code linking to bootstrap? |
Member
|
What about putting something like this in the JS? // Excerpted from the Bootstrap source, which is licensed under the MIT license:
// https://github.com/twbs/bootstrap/blob/v4.0.0-beta.3/LICENSE |
Contributor
Author
|
done now (sorry for earlier mistakes, commited on GitHub so didn't see the linting errors) |
Contributor
Author
|
awesome 👌 |
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #3667
These are derived from Bootstrap, should there be a license comment?