New playground#3573
Conversation
d542b18 to
225bfa7
Compare
|
Something's wrong in the preview (as I said, commit is pretty old) will investigate |
|
Would be really cool if Docusaurus worked like a GatsbyJS plugin. Keep the SSR, single build step, but ability to hydrate the DOM for the playground. |
|
@azz Yeah that's the gist of what I suggested in facebook/docusaurus#292 |
|
Can you deploy this somewhere, so people could test it easier? |
|
That's #3581, should be fine now. |
|
I merged the master branch, let's see if that fixes it |
|
[off-topic]: Could whoever has access to Netlify make the deploy logs publicly visible so contributors can see what wen wrong if the build fails? |
|
Sorry guys, I forgot this is based on #3433 and I removed the reference to it before creating the PR Let's see if we can land that soon... otherwise, I'll reference by the commit hash and continue work on this |
|
Yay it's finally working :) |
|
👍, but 3️⃣❓:
|
Those are great but are unrelated to this PR (2 & 3).. I mostly wanted to gather feedback if we should continue with no build steps (just serving from I think we can add separate issues for those subjects :) |
|
I don't personally care either way as long as we have a working playground at the end :) |
|
I just reviewed the code, it does look a lot better than what we have now. Do you want to bring it back up to date and land it as-is? Possibly related, I was just reading the code of https://github.com/sandhose/prettier-animated-logo which is also written with Preact, but is for the main page. Would be nice to get full |
| - error | ||
| - never | ||
| - exceptRange: true | ||
| overrides: |
There was a problem hiding this comment.
You could put this in website/playground/.eslintrc.yml instead to avoid having to use the overrides.
|
Placeholders were nice to have (or any other way to have have the sample code).. will they land in another PR if this is about to get merged or we dropping them? |
|
I'm still gonna add them in this PR.. only the range stuff I'm gonna do in another PR |
|
I ended up doing both the examples and the range feature in this PR =) Gonna merge when lint/tests pass and I do some smoke testing with the deploy preview |
|
I hate when I press merge instead of the squash button 😔 |
|
@duailibe Should we disable the other merge types (admins can do it in settings), or are there times we use them in this repo? |
|
Sgtm |


Context: #3352
This is still WIP and just a POC of a Preact app with no build steps (I opened facebook/docusaurus#292 to discuss how to reuse Docusaurus infrastructure - then we could use classes and stuff). This is very early but it was usable (commit is a few weeks old, before the big refactor).
I'm opening before finishing to gather feedback: should we keep the "no build steps" for this? It's nice having only one command and not as nice having to use two separate workflows when working on the site (one for docusarus part, other for the playground only) but it's doable.. Ideally I'd want a way to integrate with docusaurus infrastructure (transpilation, dev server, React itself).. anyway, tell me what you think!