Would this impact the behavior of something like
./prettier --write '../../some/where/else/**/*.js'?

What about monorepo/lerna-style projects, which might have something like this:

.editorconfig # establishes baseline
packages/
   foo/
     package.json
     .prettierrc # overrides something specific to foo
   bar/
     package.json
     .prettierrc

I actually don't know prettier's current behavior here, or what's desired.

I think finding the VCS directory might work?

Something like https://npmjs.com/package/find-project-root? Not sure...

Yeah @azz, I think finding the VCS directory would work far better, and handle the cases that @rattrayalex pointed out. One potential issue is that projects that don't use source control wouldn't be able to take advantage of the .editorconfig support, but I imagine that use case is vanishingly small, and being able to format files (taking .editorconfig into account) outside the current directory is far more important.

Actually, any way we could add a test for this?

Do the docs for .editorconfig claim/imply that it must exist at a VCS root? (I also assume that it typically would, so I'd probably be 👍 to this going out regardless).

I'm not sure we need a test if we're using a third-party-package that has tests. looks at npm package ah, it doesn't even have a repo listed.

Here's the tests: https://github.com/kirstein/find-project-root/blob/master/test/index.spec.js

I'd like to have one integration test for this though to document the expected behaviour.

I added a quick test in d9b2447.

I also noticed that the .prettierrc search also doesn't stop at the VCS directory, currently. We should probably fix that too.

Thanks! I'm less concerned about prettierrc because that's a more explicit intent.

Good point @azz, thanks for merging.