Skip to content

(docs) Fix broken footnote links #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duailibe merged 1 commit into from
Nov 29, 2017
Merged

(docs) Fix broken footnote links #3353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ If you want to learn more, these two conference talks are great introductions:

\* _Well actually, some original styling is preserved when practical—see [empty lines] and [multi-line objects]._

[empty lines]: rationale.md#empty-lines
[multi-line objects]: rationale.md#multi-line-objects
[empty lines]: rationale.html#empty-lines
[multi-line objects]: rationale.html#multi-line-objects
Copy link
Copy Markdown
Member

@ikatyang ikatyang Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JoelMarcey

This looks like a bug, the following two cases should be considered the same and be transformed correctly.

[aaa](bbb.md#ccc)
[aaa]

[aaa]: bbb.md#ccc

Copy link
Copy Markdown

@JoelMarcey JoelMarcey Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up @ikatyang -- we will take a look.