fix(javascript): ternary with --use-tabs#3277
Closed
ikatyang wants to merge 8 commits intoprettier:masterfrom
Closed
fix(javascript): ternary with --use-tabs#3277ikatyang wants to merge 8 commits intoprettier:masterfrom
--use-tabs#3277ikatyang wants to merge 8 commits intoprettier:masterfrom
Conversation
--use-tabs--use-tabs
Member
|
We have to read through #1026 (the PR that added tabs support) again, because as far as I remember all of this was discussed back then. When using spaces, Prettier indents with 2 spaces + 1 indent level. When using tabs, there are three ways to go:
As far as I remember, all of those were discussed with pros and cons, but I don't have the time right now to dig into it. |
--use-tabs--use-tabs
Member
Author
Since the change in the 3rd screenshot is same as the current Prettier 1.8.2 --tab-width 4Input: aaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbb : ccccccccccccccc ? ddddddddddddddd : eeeeeeeeeeeeeee ? fffffffffffffff : ggggggggggggggggOutput: aaaaaaaaaaaaaaa
? bbbbbbbbbbbbbbbbbb
: ccccccccccccccc
? ddddddddddddddd
: eeeeeeeeeeeeeee ? fffffffffffffff : gggggggggggggggg; |
Member
Author
|
Rewrite in #3745. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #2771
EDIT: After second thought, spaces should only be applied to the trailing parentheses, marking as WIP.
ideal v2
idealold