Skip to content

Revert "Respect EditorConfig settings"#3213

Merged
azz merged 2 commits intomasterfrom
revert-2760-editorconfig
Nov 9, 2017
Merged

Revert "Respect EditorConfig settings"#3213
azz merged 2 commits intomasterfrom
revert-2760-editorconfig

Conversation

@azz
Copy link
Copy Markdown
Member

@azz azz commented Nov 8, 2017

Reverts #2760 which was merged before #3204, which is needed for 1.8.2

@azz azz merged commit d2241fc into master Nov 9, 2017
@azz azz deleted the revert-2760-editorconfig branch November 9, 2017 00:39
@duailibe
Copy link
Copy Markdown
Collaborator

duailibe commented Nov 9, 2017

We should remember to comment the docs when including it again for 1.9

josephfrazier added a commit to josephfrazier/prettier that referenced this pull request Nov 12, 2017
josephfrazier added a commit to josephfrazier/prettier that referenced this pull request Nov 12, 2017
azz pushed a commit that referenced this pull request Dec 4, 2017
* Revert "Revert "Respect EditorConfig settings" (#3213)"

This reverts commit d2241fc.

* Comment out EditorConfig docs

See #3213 (comment)

* editorconfig: Support `indent_size = 0`

See #2760 (comment)
and josephfrazier/editorconfig-to-prettier@c38b84c

* Revert "Comment out EditorConfig docs"

This reverts commit ddfa529.

* Mark EditorConfig functionality as v1.9.0+

See #3255 (comment)

* editorconfig: Upgrade editorconfig-to-prettier to 0.0.4

* editorconfig: Only enable for CLI, by default

#3255 (comment)

* editorconfig: Add tests confirming that editorconfig is ignored by default in the API

#3255 (comment)

* editorconfig: Add/fix CLI option parsing

* editorconfig: Move docs from configuration.md to options.md

* editorconfig: Add `oppositeDescription` to show docs for `--no-editorconfig`

Addresses #3255 (comment)

* editorconfig: Update test snapshots

* editorconfig: Remove unnecessary options parsing code

Addresses #3255 (comment)

* editorconfig: Move docs from options.md to api.md and cli.md

Addresses #3255 (comment)

* resolveConfig: return null if both .prettierrc and .editorconfig are missing

Addresses #3255 (comment)

* Don't add now-failing tests

The way these tests work, both `tests_integration/cli/config/.prettierrc`
and `.prettierrc` apply to `tests_integration/cli/config/editorconfig/file.shouldnotexist`,
so the test wouldn't work even on master. Here's a way to confirm that:

```js
const path = require('path')
const assert = require('assert')
const prettier = require('./')

const file = './tests_integration/cli/config/editorconfig/file.shouldnotexist'
console.log(prettier.resolveConfig.sync(file))
assert(prettier.resolveConfig.sync(file) === null)
```
@giggio
Copy link
Copy Markdown

giggio commented Apr 26, 2018

@duailibe
Copy link
Copy Markdown
Collaborator

@giggio can you please open a new issue better describing the problems you are facing?

@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 26, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants