fix(markdown): no break on link#3204
Merged
azz merged 2 commits intoprettier:masterfrom Nov 8, 2017
Merged
Conversation
azz
reviewed
Nov 8, 2017
| Linters have two categories of rules: | ||
|
|
||
| **Formatting rules**: eg: [max-len](http://eslint.org/docs/rules/max-len), | ||
| [no-mixed-spaces-and-tabs](http://eslint.org/docs/rules/no-mixed-spaces-and-tabs), |
Member
Author
There was a problem hiding this comment.
Or should we only break url head if the [no-mixed-spaces-and-tabs] is breakable?
ikatyang
commented
Nov 8, 2017
| https://codecov.io/gh/prettier/prettier) []( | ||
| https://www.npmjs.com/package/prettier) [](#badge) |
Member
Author
There was a problem hiding this comment.
These looks weird but since multi-image is not common and it can be simply achieved by <!-- prettier-ignore -->, should not be a problem.
ikatyang
changed the title
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3203