Prevent breaking MemberExpression inside NewExpression#3075
Merged
azz merged 2 commits intoprettier:masterfrom Oct 21, 2017
Merged
Prevent breaking MemberExpression inside NewExpression#3075azz merged 2 commits intoprettier:masterfrom
azz merged 2 commits intoprettier:masterfrom
Conversation
azz
reviewed
Oct 20, 2017
| (firstNonMemberParent && | ||
| ((firstNonMemberParent.type === "VariableDeclarator" && | ||
| firstNonMemberParent.id.type !== "Identifier") || | ||
| (firstNonMemberParent.type === "NewExpression" || |
Collaborator
Author
There was a problem hiding this comment.
@azz I'm not sure what you meant.. what about CallExpression?
Member
There was a problem hiding this comment.
As in the same without new. It actually already behaves as expected, but I'm not sure why.
function functionName() {
// indent to make the line break
if (true) {
this._aVeryLongVariableNameToForrrrrrrBreak = this.Promise(
(resolve, reject) => {
// do something
}
);
}
}
Collaborator
Author
There was a problem hiding this comment.
Ah, understood now! That's because that case doesn't get here, actually. That's printed by printMemberChain, as you can see here:
Lines 889 to 893 in 54bdd30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3061