Skip to content

test: fix snapshots#2957

Merged
lydell merged 3 commits intoprettier:masterfrom
ikatyang:test/update-snapshots
Oct 2, 2017
Merged

test: fix snapshots#2957
lydell merged 3 commits intoprettier:masterfrom
ikatyang:test/update-snapshots

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Oct 2, 2017

Not sure why, but the build failed.

  • remove --no-color
  • use strip-ansi to enforce no colored snapshots
  • update snapshots

Fixes #2956


exports[`do not write file with --write + formated file (stdout) 1`] = `
"formated.js%s %dms
"formated.js%s %dms
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open a new issue about the %s and %d here? Looks like a bug to me.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lydell lydell merged commit d9737e6 into prettier:master Oct 2, 2017
@ikatyang ikatyang deleted the test/update-snapshots branch October 2, 2017 23:39
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 19, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants