Normalize numbers in CSS like JS#2627
Merged
lydell merged 2 commits intoprettier:masterfrom Aug 22, 2017
Merged
Conversation
2 tasks
Member
Author
|
Yay, the tests passed when I switched postcss-values-parser to shellscape/postcss-values-parser#36 Do we want to wait for shellscape/postcss-values-parser#36 to be merged first? |
Contributor
|
Woow, thanks for doing that :) It would be better if it was merged but if it takes too long to get it reviewed, feel free to hit the merge button :) |
vjeux
approved these changes
Aug 16, 2017
Contributor
|
Looks like the other PR is not being reviewed, so feel free to merge. |
Unlike JS, `1.0` is also normalized to `1`.
|
@lydell the updated SHA af2c80b2bb558a6e7d61540d97f068f9fa162b38 of postcss-values-parser repo doesn't seem to exist. I'm unable to setup the pre-commit hook because of this. |
Member
Author
|
@gaganjakhotiya Oops! I accidentally deleted the branch when my PR was merged :( It should be back now. Good catch! |
This was referenced Sep 27, 2017
Merged
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike JS,
1.0is also normalized to1.