Handle closure compiler type cast syntax correctly#2484
Conversation
| const text = options.originalText; | ||
| if (util.hasNewline(text, util.skipNewline(text, util.locEnd(comment)))) { | ||
| leadingParts.push(hardline); | ||
| } else if (util.isClosureCompilerTypeCastComment(text, comment)) { |
There was a problem hiding this comment.
I'm wondering if this can instead be handled in fast-path.js's needsParens function.
There was a problem hiding this comment.
Agreed. Could you look into it? If that works that would be cleaner.
|
Any idea how this will play with flow comment types? |
| // Syntax example: var x = /** @type {string} */ (fruit); | ||
| return ( | ||
| isBlockComment(comment) && | ||
| comment.value.match(/^\*\s+@type\s+{[^}]+}\s+$/) && |
There was a problem hiding this comment.
probably want to use \s* instead of \s+ and add some inside of {}
There was a problem hiding this comment.
Oops. that's what i meant to use.
|
Thanks for working on it! |
|
@azz I tested a few variations of the flow comment type syntax and it seems that the changes I made to how comments are attached behave correctly. |
| // Syntax example: var x = /** @type {string} */ (fruit); | ||
| return ( | ||
| node.comments && | ||
| node.comments.every( |
Codecov Report
@@ Coverage Diff @@
## master #2484 +/- ##
=========================================
Coverage ? 94.98%
=========================================
Files ? 24
Lines ? 3291
Branches ? 867
=========================================
Hits ? 3126
Misses ? 150
Partials ? 15
Continue to review full report at Codecov.
|
|
@azz didn't you disable codecov comments? |
|
@vjeux I certainly did... Maybe needs rebase? |
yangsu
force-pushed
the
support-closure-type-cast-syntax
branch
from
0c592ab to
f5b43ae
Compare
yangsu
force-pushed
the
support-closure-type-cast-syntax
branch
from
f5b43ae to
bbbb1cf
Compare
|
Heh, your comment appeared right as I clicked the merge button. |
lock
Bot
added
the
locked-due-to-inactivity
3 participants
Fixes #1445