Skip to content

Force trailingComma option to "none" when parser is JSON#2335

Merged
vjeux merged 3 commits intoprettier:masterfrom
josephfrazier:json-ignore-trailing-comma
Jun 28, 2017
Merged

Force trailingComma option to "none" when parser is JSON#2335
vjeux merged 3 commits intoprettier:masterfrom
josephfrazier:json-ignore-trailing-comma

Conversation

@josephfrazier
Copy link
Copy Markdown
Collaborator

This fixes #2308

@vjeux
Copy link
Copy Markdown
Contributor

vjeux commented Jun 28, 2017

Thanks!

@vjeux vjeux merged commit 175cde1 into prettier:master Jun 28, 2017
@josephfrazier josephfrazier deleted the json-ignore-trailing-comma branch June 28, 2017 16:30
azz pushed a commit that referenced this pull request Jul 15, 2017
* Run JSON tests with `trailingComma: "all"`

* Add test of `parser: 'json', trailingComma: 'all'` with non-.json extension

See #2308 (comment)

* Force trailingComma option to "none" when parser is JSON

This fixes #2308
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 19, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trailing Comma "all" setting breaking JSON

2 participants