Break decorator before content#2032
Merged
vjeux merged 1 commit intoprettier:masterfrom Jun 7, 2017
Merged
Conversation
vjeux
commented
Jun 7, 2017
| ? "" | ||
| : "@"; | ||
| parts.push(prefix, printPath(decoratorPath), line); | ||
| decorators.push(prefix, printPath(decoratorPath), hardline); |
Contributor
Author
There was a problem hiding this comment.
line used to work by accident, because we didn't have any group so the other properties would likely make it break. We always do want to break here.
blowery
added a commit
to Automattic/wp-prettier
that referenced
this pull request
Jun 21, 2017
* tag '1.4.4': (421 commits) 1.4.4 1.4.3 Clean up build script, add Babel for docs js bundles (prettier#1970) Check if the next group has comments (prettier#2040) Include typeAnnotation inside of node location (prettier#2039) Fix decorator comments for export class (prettier#2038) Add group around TSMethodSignature (prettier#2037) Do not throw for unprinted comments inside of JSX (prettier#2036) Break decorator before content (prettier#2032) Fix less &:extends when parsed with scss (prettier#2034) Fix parenthesis for call expression inside of member expression inside of new (prettier#2035) Break if string | null (prettier#2028) Only prevent lone `set` if there's no type annotations (prettier#2026) Add semi for functions without body (prettier#2025) Update commands.md Update commands.md Pretty printer commands.js GraphQL: Add support for union types (prettier#2014) Update README for emacs integration link (prettier#2024) Add alias and null value (prettier#2017) ...
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1996