Repository navigation
Keep nested emphasis around a bare URL from becoming strong emphasis - #20128
Open
HuzaifaChaudary wants to merge 1 commit into
Open
HuzaifaChaudary wants to merge 1 commit into
HuzaifaChaudary wants to merge 1 commit into
Conversation
an emphasis that starts with an autolink keeps the delimiter it was written with . the emphasis around it did not know that and picked `_` too , so `*_https://a.b_*` came out as `__https://a.b__` , which is strong emphasis , and the next format turned it into `**https://a.b**` . the parent now keeps its written delimiter as well . the issue case is pinned in emphasis/issue-8654.md . 18 of the 24 nested wrappers commented out in the auto-link test pass now and are turned back on , 4 of their cases fail on main . the other 6 wrappers still fail the same way on main for a different reason and stay commented out . Co-Authored-By: Claude Opus 5 <[email protected]>
HuzaifaChaudary
force-pushed
the
fix/markdown-autolink-emphasis
branch
from
September 22, 2026 00:06
59f7dde to
d45a881
Compare
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #8654
an emphasis that starts with a bare url keeps the delimiter it was written with , since changing it next to a url can change where the url ends . the emphasis around it did not know that and picked
_too , so*_https://example.com_*came out as__https://example.com__, which is strong emphasis , and the next run turned it into**https://example.com**. now the outer one keeps its written delimiter as well , so the input comes back as it was .the auto-link test had 24 nested wrappers commented out . 18 of them pass now and are turned back on , 4 of their cases fail without this change and the rest already passed on main . the other 6 still fail on main for a different reason , a literal
_or*right next to the url that is not a delimiter , so they stay commented out . the issue case is pinned inemphasis/issue-8654.md.Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.