Repository navigation
Conversation
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
I think the problem here is that we need print parenthesis for some cases. Prettier PR #19916 --parser typescriptInput: (obj.aaa /*
c */)!.substring(0);Output: obj
.aaa /*
c */!
.substring(0);Second Output: SyntaxError: Expression expected. (4:3)
2 | .aaa /*
3 | c */!
> 4 | .substring(0);
| ^
5 | |
kovsu
commented
Aug 25, 2026
| (followingNode?.type === "Identifier" || | ||
| (enclosingNode.computed && | ||
| precedingNode?.type === "TSNonNullExpression" && | ||
| followingNode === enclosingNode.property)) |
kovsu
commented
Aug 25, 2026
Comment on lines
+247
to
+256
| if ( | ||
| currentGroup.length > 0 && | ||
| isMemberExpression(printedNodes[i].node) && | ||
| hasComment(printedNodes[i].node, CommentCheckFlags.Leading) | ||
| ) { | ||
| groups.push(currentGroup); | ||
| currentGroup = []; | ||
| hasSeenCallExpression = false; | ||
| } | ||
|
|
Collaborator
Author
Fixed, see link |
fisker
reviewed
Aug 25, 2026
fisker
reviewed
Aug 26, 2026
| return false; | ||
| } | ||
|
|
||
| if (shouldAddParenthesesToNonNullOperand(path, options)) { |
Member
There was a problem hiding this comment.
Let's move it to parentNeedsParentheses().
fisker
reviewed
Aug 26, 2026
| !needsParentheses(path, options) | ||
| !needsParentheses(path, options) && | ||
| !path.call( | ||
| () => shouldAddParenthesesToNonNullOperand(path, options), |
Member
There was a problem hiding this comment.
Let's call needsParentheses() instead, maybe also check node.type, since we don't want print own comments for other nodes.
fisker
reviewed
Aug 26, 2026
|
|
||
| doc = printCommentsForFunction(path, options, doc); | ||
|
|
||
| if (shouldAddParenthesesToNonNullOperand(path, options)) { |
Member
There was a problem hiding this comment.
2 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12529
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.