Translate cursor relative to nearest node, not SourceElement#1989
Merged
vjeux merged 3 commits intoprettier:masterfrom Jun 6, 2017
Merged
Translate cursor relative to nearest node, not SourceElement#1989vjeux merged 3 commits intoprettier:masterfrom
vjeux merged 3 commits intoprettier:masterfrom
Conversation
This partially address prettier#1981 See prettier#1981 (comment)
Since the `cursorOffset` option (introduced in prettier#1637) works by tracking the cursor position relative to an AST node (rather than a CST token), it can produce incorrect results. See prettier#1981
josephfrazier
commented
Jun 5, 2017
| const code = "return 15"; | ||
| expect(prettier.formatWithCursor(code, { cursorOffset: 14 })).toEqual({ | ||
| formatted: "return 15;\n", | ||
| cursorOffset: 14 // TODO fix this |
Collaborator
Author
There was a problem hiding this comment.
Note that the result offset is nevertheless outside the node, since the cursor is one space before the 15, so we still need something like #1983 (or maybe some logic that finds the "nearest" node to the cursor, rather than the smallest one containing the cursor).
lock
Bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially address #1981
See #1981 (comment)