Skip to content

Clean up build script, add Babel for docs js bundles#1970

Merged
vjeux merged 2 commits intoprettier:masterfrom
ndresx:update-docs-build-compatibility
Jun 7, 2017
Merged

Clean up build script, add Babel for docs js bundles#1970
vjeux merged 2 commits intoprettier:masterfrom
ndresx:update-docs-build-compatibility

Conversation

@ndresx
Copy link
Copy Markdown
Contributor

@ndresx ndresx commented Jun 5, 2017

As discussed here (#1928), I have removed the no longer used build:docs script as well as added Babel for index.js and parser-babylon.js in the docs folder to make them work in browsers (like Safari) who do not support various language features - in strict mode - yet.

In addition, I have cleaned up the build script.

@ndresx
Copy link
Copy Markdown
Contributor Author

ndresx commented Jun 5, 2017

Need to resolve the conflict - will either happen later today, or tomorrow.

Copy link
Copy Markdown
Contributor

@vjeux vjeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Once you fix the merge conflict and make the dep exact, you're good to go!

Comment thread package.json Outdated
"main": "./index.js",
"dependencies": {},
"devDependencies": {
"babel-cli": "^6.24.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use exact dependencies please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have changed it.

@vjeux
Copy link
Copy Markdown
Contributor

vjeux commented Jun 5, 2017

By the way, as you've probably seen, the build step generates a ton of logs and warnings. I haven't had the time to try and clean them up, if that's something your interested in, that would be awesome to fix!

@ndresx ndresx force-pushed the update-docs-build-compatibility branch from 12e8e69 to fccd76b Compare June 6, 2017 18:46
@ndresx
Copy link
Copy Markdown
Contributor Author

ndresx commented Jun 6, 2017

Hi, have rebased it with master now and tried to clean up the build script a little bit more, hopefully not too much when it comes to ignoring certain rollup warnings.

@ndresx ndresx changed the title Add Babel for docs js bundles and remove old build:docs script Clean up build script, add Babel for docs js bundles Jun 6, 2017
@vjeux
Copy link
Copy Markdown
Contributor

vjeux commented Jun 7, 2017

Ohh, sorry I didn't see the update. We shouldn't update the docs mid-release since it won't reflect what you have on npm. If you could remove that, I'll merge it in. Sorry for the delay :(

@vjeux
Copy link
Copy Markdown
Contributor

vjeux commented Jun 7, 2017

Actually, i'm just doing a release, so i'll just merge it in.

@vjeux vjeux merged commit 820e39b into prettier:master Jun 7, 2017
@ndresx
Copy link
Copy Markdown
Contributor Author

ndresx commented Jun 7, 2017

Sorry, and thank you!

vjeux added a commit that referenced this pull request Jun 7, 2017
* Fix support for node 4 (#1988)
* Fix website on iOS Safari (#1970)

Formatting change:
* Position JSX whitespace (`{" "}`) at the end of lines (#1964)

Lots of small fixes, mainly for TypeScript.
blowery added a commit to Automattic/wp-prettier that referenced this pull request Jun 21, 2017
* tag '1.4.4': (421 commits)
  1.4.4
  1.4.3
  Clean up build script, add Babel for docs js bundles (prettier#1970)
  Check if the next group has comments (prettier#2040)
  Include typeAnnotation inside of node location (prettier#2039)
  Fix decorator comments for export class (prettier#2038)
  Add group around TSMethodSignature (prettier#2037)
  Do not throw for unprinted comments inside of JSX (prettier#2036)
  Break decorator before content (prettier#2032)
  Fix less &:extends when parsed with scss (prettier#2034)
  Fix parenthesis for call expression inside of member expression inside of new (prettier#2035)
  Break if string | null (prettier#2028)
  Only prevent lone `set` if there's no type annotations (prettier#2026)
  Add semi for functions without body (prettier#2025)
  Update commands.md
  Update commands.md
  Pretty printer commands.js
  GraphQL: Add support for union types (prettier#2014)
  Update README for emacs integration link (prettier#2024)
  Add alias and null value (prettier#2017)
  ...
@lock lock Bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 20, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants