Add shebang comment nodes to Flow/TypeScript ASTs#1905
Merged
vjeux merged 2 commits intoprettier:masterfrom Jun 2, 2017
Merged
Add shebang comment nodes to Flow/TypeScript ASTs#1905vjeux merged 2 commits intoprettier:masterfrom
vjeux merged 2 commits intoprettier:masterfrom
Conversation
Now we handle actually printing the shebang in `printComment`, rather than lopping it off beforehand and reattaching it afterward, as suggested in prettier#1718 (comment)
Contributor
|
Thanks! |
This was referenced Jun 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we handle actually printing the shebang in
printComment, rather thanlopping it off beforehand and reattaching it afterward, as suggested in
#1718 (comment)