Skip to content

[Remark 11] WIP: adjust blank lines tweaking AST#18498

Closed
seiyab wants to merge 9 commits intoprettier:remark-11-markdownfrom
seiyab:remark-11-adjust-blank-lines-tweak-ast
Closed

[Remark 11] WIP: adjust blank lines tweaking AST#18498
seiyab wants to merge 9 commits intoprettier:remark-11-markdownfrom
seiyab:remark-11-adjust-blank-lines-tweak-ast

Conversation

@seiyab
Copy link
Copy Markdown
Collaborator

@seiyab seiyab commented Dec 17, 2025

Description

Status: Still in progress. Just sharing approaches.

Other approaches (does not work yet):

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 17, 2025

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/[email protected]
yarn add https://pkg.pr.new/@prettier/[email protected]
yarn add https://pkg.pr.new/[email protected]

commit: ea5cf44

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 17, 2025

Deploy Preview for prettier ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2fe2024
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/6942c1715e34df00082851be
😎 Deploy Preview https://deploy-preview-18498--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@seiyab seiyab changed the base branch from main to remark-11-markdown December 17, 2025 14:45
}
}

function transformInlineHtml(ast) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to join inline html into previous paragraph.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 17, 2025

Deploy Preview for prettier ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ea5cf44
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/694406eacaf0d30008051a48
😎 Deploy Preview https://deploy-preview-18498--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@seiyab
Copy link
Copy Markdown
Collaborator Author

seiyab commented Dec 18, 2025

@fisker
#18467 misses following case 😢 :

Prettier pr-18277
Playground link

--parser markdown

Input:

<unknown title="line 1
  line 2
"></unknown>

abc <unknown title="line 1
  line 2
"></unknown>

Output:

<unknown title="line 1
  line 2
"></unknown>

abc <unknown title="line 1
line 2
"></unknown>

I'll inspect parser again.

@seiyab seiyab closed this Dec 19, 2025
@seiyab seiyab mentioned this pull request Dec 22, 2025
4 tasks
@seiyab seiyab mentioned this pull request Mar 26, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant