Skip to content

Upgrade to latest micromark (markdown only)#18277

Merged
fisker merged 128 commits intomainfrom
remark-11-markdown
Dec 26, 2025
Merged

Upgrade to latest micromark (markdown only)#18277
fisker merged 128 commits intomainfrom
remark-11-markdown

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Nov 18, 2025

Description

Playground

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@seiyab
Copy link
Copy Markdown
Collaborator

seiyab commented Dec 17, 2025

Prettier pr-18277
Playground link

--parser markdown

Input:

tex
<em>text</em>

![OpenWebDocs Logo: Carle the book worm](carle.png)
<img alt="OpenWebDocs Logo: Carle the book worm" src="carle.png" />

Output:

tex

<em>text</em>

![OpenWebDocs Logo: Carle the book worm](carle.png)

<img alt="OpenWebDocs Logo: Carle the book worm" src="carle.png" />

seiyab and others added 3 commits December 21, 2025 23:46
# Conflicts:
#	src/language-markdown/clean.js
#	src/language-markdown/print/mdast.js
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Dec 21, 2025

As a consequence of #18467

Prettier pr-18277
Playground link

--parser markdown

Input:

- <div>html</div>            text
- <span>html</span>            text

Output:

- <div>html</div>            text
- <span>html</span>            text

But without that hack, it formats to

- <div>html</div>            text
- <span>html</span> text

Not sure if we should do somthing.

* * *

=====================================output=====================================
---
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can potentially change the <hr> to front matter. But I think it's fine to let it go.

Prettier pr-18277
Playground link

--parser markdown

Input:

* * *
something: not-front-matter
---

Output:

---

something: not-front-matter
---

Second Output:

---
something: not-front-matter
---

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Dec 26, 2025

@seiyab

I plan to merge this PR and continue work on the MDX upgrade. Do you have any work left that you want to finish before I merge?

Are you fine with squashing all these changes into one commit?

@fisker fisker marked this pull request as ready for review December 26, 2025 08:21
@seiyab
Copy link
Copy Markdown
Collaborator

seiyab commented Dec 26, 2025

Do you have any work left that you want to finish before I merge?

I wonder if we need to see loose list item in block quote (seen in MDN integration test).
In my opinion, trivial ones, that won't block release, will be able to be worked on the main branch after this will be merged. I'm neutral for the loose list item diff.

Are you fine with squashing all these changes into one commit?

Yes 😁

@fisker fisker merged commit 6c339cd into main Dec 26, 2025
43 checks passed
@fisker fisker deleted the remark-11-markdown branch December 26, 2025 11:43
@karlhorky
Copy link
Copy Markdown
Contributor

karlhorky commented Dec 27, 2025

@fisker @seiyab congratulations getting a PR merged in the direction of getting new MDX versions supported! 🙌 🎉

Looking forward to this landing in a Prettier version!

cc @wooorm @ChristianMurphy @remcohaszing in case you weren't following along already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants