Skip to content

Comments

Fix inconsistent call print between CallExpression and NewExpression#18206

Merged
fisker merged 9 commits intoprettier:mainfrom
fisker:18171-2
Nov 17, 2025
Merged

Fix inconsistent call print between CallExpression and NewExpression#18206
fisker merged 9 commits intoprettier:mainfrom
fisker:18171-2

Conversation

@fisker
Copy link
Member

@fisker fisker commented Nov 3, 2025

Description

Ref #18171
Fixes #18247

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 3, 2025

Open in StackBlitz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/[email protected]
yarn add https://pkg.pr.new/prettier/prettier/@prettier/[email protected]
yarn add https://pkg.pr.new/prettier/[email protected]

commit: 48c9bf0

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for prettier ready!

Name Link
🔨 Latest commit 48c9bf0
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/691b2dc8f40f0a000802838b
😎 Deploy Preview https://deploy-preview-18206--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker
Copy link
Member Author

fisker commented Nov 3, 2025

This was added in

#3075

to fix

#3061

Should not break this case

function completeMultipartUpload() {
  if (!this._completeMultipartUploadPromise) {
    this._completeMultipartUploadPromise = new this.Promise.Promise.Promise.Promise.Promise.Promise.Promise.Promise.Promise.Promise.Promise(
      (resolve, reject) => {
        this.fileTransfer.completeMultipartUpload((err, data) => {
          if (err) {
            this._completeMultipartUploadPromise = null;
            reject(err);
          } else {
            resolve(data);
          }
        });
      }
    );
  }
}

@fisker fisker marked this pull request as ready for review November 17, 2025 14:42
@fisker fisker merged commit 35718f2 into prettier:main Nov 17, 2025
35 checks passed
@fisker fisker deleted the 18171-2 branch November 17, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent formatting logic of CallExpression and NewExpression

1 participant