Skip to content

Forbid empty type argument/parameter list in oxc-ts parser#17870

Merged
fisker merged 2 commits intoprettier:mainfrom
fisker:empty-type-argument-oxc
Sep 22, 2025
Merged

Forbid empty type argument/parameter list in oxc-ts parser#17870
fisker merged 2 commits intoprettier:mainfrom
fisker:empty-type-argument-oxc

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Sep 9, 2025

Description

We already forbid it in other typescript parsers,

typescript-eslint #17868
babelts #17869

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@fisker fisker marked this pull request as draft September 9, 2025 14:37
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 9, 2025

Open in StackBlitz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/[email protected]
yarn add https://pkg.pr.new/prettier/prettier/@prettier/[email protected]
yarn add https://pkg.pr.new/prettier/[email protected]

commit: d2c528b

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 9, 2025

Deploy Preview for prettier ready!

Name Link
🔨 Latest commit d2c528b
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/68d18e392b41480007125528
😎 Deploy Preview https://deploy-preview-17870--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker fisker force-pushed the empty-type-argument-oxc branch from b180976 to e5a0953 Compare September 22, 2025 10:59
@fisker fisker marked this pull request as ready for review September 22, 2025 18:09
@fisker fisker merged commit e2789c3 into prettier:main Sep 22, 2025
33 checks passed
@fisker fisker deleted the empty-type-argument-oxc branch September 22, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant